Skip to content

Compute air density for coupling with wave model at the 2-m level#3

Open
wlanghans wants to merge 1 commit intowolfgang/rebase_sofar-071124_on_mainfrom
wolfgang/compute_rho_at_2m
Open

Compute air density for coupling with wave model at the 2-m level#3
wlanghans wants to merge 1 commit intowolfgang/rebase_sofar-071124_on_mainfrom
wolfgang/compute_rho_at_2m

Conversation

@wlanghans
Copy link
Copy Markdown

Description

This moves the computation of the air density from the surface layer parameterization to the sfc_diag routine that handles the diagnostics. There, it is computed for the 2-m level. This will ensure that the density reflects well on the density jump at the water/air interface and ensures that it is independent of the height of the first model level.

Fixes # (issue)

How Has This Been Tested?
Not yet.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Collaborator

@StevePny StevePny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're getting rhoa from sfcprop already in the fv3 cap. Does this overwrite the value in that data structure?

IPD_Data(nb)%Sfcprop%rhoa

We'll need to test this for at least one experiment run with the coupled model (e.g. 2/15/24) before merging.

@wlanghans
Copy link
Copy Markdown
Author

I think we're getting rhoa from sfcprop already in the fv3 cap. Does this overwrite the value in that data structure?

IPD_Data(nb)%Sfcprop%rhoa

We'll need to test this for at least one experiment run with the coupled model (e.g. 2/15/24) before merging.

Yes, it overwrites it with the new definition. Agree on testing this in the coupled model.

@wlanghans
Copy link
Copy Markdown
Author

I think we're getting rhoa from sfcprop already in the fv3 cap. Does this overwrite the value in that data structure?

IPD_Data(nb)%Sfcprop%rhoa

We'll need to test this for at least one experiment run with the coupled model (e.g. 2/15/24) before merging.

@StevePny What's the change you are requesting?

@miguelsolanocordoba What branch should this het merged into to test it in the coupled model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants